From 786e11266fe738220e60a6a2f9c51280bd79240c Mon Sep 17 00:00:00 2001
From: Julien Cabillot <julien.cabillot@ubisoft.com>
Date: Mon, 18 Apr 2022 13:55:13 -0400
Subject: [PATCH] test avec la lib

---
 charts/offlineimap/Chart.yaml             |  2 +-
 charts/offlineimap/templates/common.yaml  |  4 +---
 charts/offlineimap/templates/cronjob.yaml | 12 +++++++++---
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/charts/offlineimap/Chart.yaml b/charts/offlineimap/Chart.yaml
index c05608f..bbfee0c 100644
--- a/charts/offlineimap/Chart.yaml
+++ b/charts/offlineimap/Chart.yaml
@@ -3,7 +3,7 @@ apiVersion: v2
 description: Helm chart for offlineimap
 name: offlineimap
 type: application
-version: 0.0.15
+version: 0.0.16
 kubeVersion: ">=1.16.0-0"
 keywords:
 - offlineimap
diff --git a/charts/offlineimap/templates/common.yaml b/charts/offlineimap/templates/common.yaml
index bfc9048..b8a5706 100644
--- a/charts/offlineimap/templates/common.yaml
+++ b/charts/offlineimap/templates/common.yaml
@@ -3,8 +3,6 @@
 
 {{/* custom render */}}
 
-{{- include "common.pvc" . }}
-
 {{- if .Values.secret -}}
   {{ include "common.secret" .  | nindent 0 }}
-{{- end -}}
\ No newline at end of file
+{{- end -}}
diff --git a/charts/offlineimap/templates/cronjob.yaml b/charts/offlineimap/templates/cronjob.yaml
index 5303e9f..62a1d2b 100644
--- a/charts/offlineimap/templates/cronjob.yaml
+++ b/charts/offlineimap/templates/cronjob.yaml
@@ -55,9 +55,15 @@ spec:
               {{- end }}
             {{- end }}
             volumeMounts:
+            # TODO: ici on pourrait essayer de simplement faire un include common.controller.volumeMounts
             - name: dump
               mountPath: /dump
+          {{- with (include "common.controller.volumes" . | trim) }}
           volumes:
-            - name: dump
-              persistentVolumeClaim:
-                claimName: {{ include "common.names.fullname" . }}-dump
\ No newline at end of file
+            {{- nindent 2 . }}
+          {{- end }}
+          # volumes:
+            # - name: dump
+            #   hostPath:
+            #     path: 
+            #     type:
\ No newline at end of file