perso/syncserver
perso/syncserver
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add "force_wsgi_environ" config option.

Browse Source 
This is the nuclear option for when your reverse proxy setup doesn't
place nicely with our request-signing thing - it causes the app to
unilaterally clobber its WSGI environment with values from public_url.
This commit is contained in:
Ryan Kelly 2015-02-13 16:26:17 +11:00
parent 24dbda8f41
commit c4c0fa033a
2 changed files with 28 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
syncserver.ini
View File

@ -27,8 +27,16 @@ public_url = http://localhost:5000/
# Only request by existing accounts will be honoured. # Only request by existing accounts will be honoured.
# allow_new_users = false # allow_new_users = false
# Set this to "true" to work around a mismatch between public_url and
# the application URL as seen by python, which can happen in certain reverse-
# proxy hosting setups. It will overwrite the WSGI environ dict with the
# details from public_url. This could have security implications if e.g.
# you tell the app that it's on HTTPS but it's really on HTTP, so it should
# only be used as a last resort and after careful checking of server config.
force_wsgi_environ = false
# Uncomment and edit the following to use a local BrowserID verifier # Uncomment and edit the following to use a local BrowserID verifier
# rather than posing assertions to the mozilla-hosted verifier. # rather than posting assertions to the mozilla-hosted verifier.
# Audiences should be set to your public_url without a trailing slash. # Audiences should be set to your public_url without a trailing slash.
#[browserid] #[browserid]
#backend = tokenserver.verifiers.LocalVerifier #backend = tokenserver.verifiers.LocalVerifier

31
syncserver/__init__.py
View File

@ -117,24 +117,27 @@ def reconcile_wsgi_environ_with_public_url(event):
# is serving us at some sub-path. # is serving us at some sub-path.
if not request.script_name: if not request.script_name:
request.script_name = p_public_url.path.rstrip("/") request.script_name = p_public_url.path.rstrip("/")
# If the public_url claims we're on a non-standard port but the environ # If the environ does not match public_url, requests are almost certainly
# says we're on a standard port, assume the public_url is correct. # going to fail due to auth errors. We can either bail out early, or we
# This is often the case with e.g. apache mod_wsgi. # can forcibly clobber the WSGI environ with the values from public_url.
if p_public_url.port not in (None, 80, 443): # This is a security risk if you've e.g. mis-configured the server, so
port_str = str(p_public_url.port) # it's not enabled by default.
if request.host_port != port_str:
if request.host_port in (None, "80", "443"):
request.host = p_public_url.netloc
# Log a noisy error if the application url is different to what we'd
# expect based on public_url setting.
application_url = request.application_url application_url = request.application_url
if public_url != application_url: if public_url != application_url:
msg = "The public_url setting does not match the application url.\n" if not request.registry.settings.get("syncserver.force_wsgi_environ"):
msg += "This will almost certainly cause authentication failures!\n" msg = "\n".join((
msg += " public_url setting is: %s\n" % (public_url,) "The public_url setting doesn't match the application url.",
msg += " application url is: %s\n" % (application_url,) "This will almost certainly cause authentication failures!",
" public_url setting is: %s" % (public_url,),
" application url is: %s" % (application_url,),
"You can disable this check by setting the force_wsgi_environ",
"option in your config file, but do so at your own risk.",
))
logger.error(msg) logger.error(msg)
raise _JSONError([msg], status_code=500) raise _JSONError([msg], status_code=500)
request.scheme = p_public_url.scheme
request.host = p_public_url.netloc
request.script_name = p_public_url.path.rstrip("/")
def get_configurator(global_config, **settings): def get_configurator(global_config, **settings):