lib/nat: Add a nat package and service to track mappings on multiple IGDs

lib/util/random.go

@@ -17,16 +17,6 @@ import (
 // randomCharset contains the characters that can make up a randomString().
 const randomCharset = "01234567890abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ-"
 
-// PredictableRandom is an RNG that will always have the same sequence. It
-// will be seeded with the device ID during startup, so that the sequence is
-// predictable but varies between instances.
-var PredictableRandom = mathRand.New(mathRand.NewSource(42))
-
-func init() {
-	// The default RNG should be seeded with something good.
-	mathRand.Seed(RandomInt64())
-}
-
 // RandomString returns a string of random characters (taken from
 // randomCharset) of the specified length.
 func RandomString(l int) string {

lib/util/random_test.go

@@ -6,26 +6,7 @@
 
 package util
 
-import (
-	"runtime"
-	"sync"
-	"testing"
-)
-
-var predictableRandomTest sync.Once
-
-func TestPredictableRandom(t *testing.T) {
-	if runtime.GOARCH != "amd64" {
-		t.Skip("Test only for 64 bit platforms; but if it works there, it should work on 32 bit")
-	}
-	predictableRandomTest.Do(func() {
-		// predictable random sequence is predictable
-		e := int64(3440579354231278675)
-		if v := int64(PredictableRandom.Int()); v != e {
-			t.Errorf("Unexpected random value %d != %d", v, e)
-		}
-	})
-}
+import "testing"
 
 func TestSeedFromBytes(t *testing.T) {
 	// should always return the same seed for the same bytes