From f062e356416ed2480500b4bdaa542608bb252b9b Mon Sep 17 00:00:00 2001 From: kluppy Date: Sat, 28 Nov 2015 02:46:06 +1000 Subject: [PATCH] Don't chmod in Atomic on android (fixes #2472) --- lib/osutil/atomic.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/osutil/atomic.go b/lib/osutil/atomic.go index 94f306ad..736d2f86 100644 --- a/lib/osutil/atomic.go +++ b/lib/osutil/atomic.go @@ -37,10 +37,13 @@ func CreateAtomic(path string, mode os.FileMode) (*AtomicWriter, error) { return nil, err } - if err := os.Chmod(fd.Name(), mode); err != nil { - fd.Close() - os.Remove(fd.Name()) - return nil, err + // chmod fails on Android so don't even try + if runtime.GOOS != "android" { + if err := os.Chmod(fd.Name(), mode); err != nil { + fd.Close() + os.Remove(fd.Name()) + return nil, err + } } w := &AtomicWriter{