From 6b1d7ac727c523d11096e99ed3faaadd8ad095d1 Mon Sep 17 00:00:00 2001 From: Simon Frei Date: Fri, 14 Jun 2019 13:14:15 +0200 Subject: [PATCH] gui: Check data before calling .reverse() (#5793) --- gui/default/syncthing/core/syncthingController.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gui/default/syncthing/core/syncthingController.js b/gui/default/syncthing/core/syncthingController.js index ccd01ec8..ea7a97f1 100755 --- a/gui/default/syncthing/core/syncthingController.js +++ b/gui/default/syncthing/core/syncthingController.js @@ -726,6 +726,11 @@ angular.module('syncthing.core') var refreshGlobalChanges = debounce(function () { $http.get(urlbase + "/events/disk?limit=25").success(function (data) { + if (!data) { + // For reasons unknown this is called with data being the empty + // string on shutdown, causing an error on .reverse(). + return; + } data = data.reverse(); $scope.globalChangeEvents = data; console.log("refreshGlobalChanges", data);