From 911c148c71a11f159a8863c54327dce661cc42e3 Mon Sep 17 00:00:00 2001
From: Jakob Borg <jakob@kastelo.net>
Date: Thu, 24 Nov 2016 11:33:43 +0100
Subject: [PATCH] build: Improve setup, add metalint ineffasign

---
 build.go | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/build.go b/build.go
index 3d139a66..fcd9dfdd 100644
--- a/build.go
+++ b/build.go
@@ -298,6 +298,7 @@ func runCommand(cmd string, target target) {
 			ok := gometalinter("deadcode", dirs, "test/util.go")
 			ok = gometalinter("structcheck", dirs) && ok
 			ok = gometalinter("varcheck", dirs) && ok
+			ok = gometalinter("ineffassign", dirs) && ok
 			if !ok {
 				os.Exit(1)
 			}
@@ -356,14 +357,22 @@ func checkRequiredGoVersion() (float64, bool) {
 }
 
 func setup() {
-	runPrint("go", "get", "-u", "-v", "github.com/golang/lint/golint")
-	runPrint("go", "get", "-u", "-v", "golang.org/x/tools/cmd/cover")
-	runPrint("go", "get", "-u", "-v", "golang.org/x/net/html")
-	runPrint("go", "get", "-u", "-v", "github.com/FiloSottile/gvt")
-	runPrint("go", "get", "-u", "-v", "github.com/axw/gocov/gocov")
-	runPrint("go", "get", "-u", "-v", "github.com/AlekSi/gocov-xml")
-	runPrint("go", "get", "-u", "-v", "github.com/alecthomas/gometalinter")
-	runPrint("go", "get", "-u", "-v", "github.com/mitchellh/go-wordwrap")
+	packages := []string{
+		"github.com/alecthomas/gometalinter",
+		"github.com/AlekSi/gocov-xml",
+		"github.com/axw/gocov/gocov",
+		"github.com/FiloSottile/gvt",
+		"github.com/golang/lint/golint",
+		"github.com/gordonklaus/ineffassign",
+		"github.com/mitchellh/go-wordwrap",
+		"github.com/opennota/check/cmd/...",
+		"golang.org/x/net/html",
+		"golang.org/x/tools/cmd/cover",
+	}
+	for _, pkg := range packages {
+		fmt.Println(pkg)
+		runPrint("go", "get", "-u", pkg)
+	}
 }
 
 func test(pkgs ...string) {