From abd363e8bb8d2abe34601f3657a9badbbc0b8b27 Mon Sep 17 00:00:00 2001 From: Simon Frei Date: Fri, 14 Jun 2019 08:48:14 +0200 Subject: [PATCH] lib/model: Don't error on pulling deletion of invalid file (fixes #5791) (#5792) --- lib/model/folder_sendrecv.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/model/folder_sendrecv.go b/lib/model/folder_sendrecv.go index c01b34cf..b682a90a 100644 --- a/lib/model/folder_sendrecv.go +++ b/lib/model/folder_sendrecv.go @@ -326,7 +326,17 @@ func (f *sendReceiveFolder) processNeeded(dbUpdateChan chan<- dbUpdateJob, copyC changed++ case runtime.GOOS == "windows" && fs.WindowsInvalidFilename(file.Name): - f.newPullError(file.Name, fs.ErrInvalidFilename) + if file.IsDeleted() { + // Just pretend we deleted it, no reason to create an error + // about a deleted file that we can't have anyway. + // Reason we need it in the first place is, that it was + // ignored at some point. + dbUpdateChan <- dbUpdateJob{file, dbUpdateDeleteFile} + changed++ + } else { + // We can't pull an invalid file. + f.newPullError(file.Name, fs.ErrInvalidFilename) + } case file.IsDeleted(): if file.IsDirectory() {