build: Enable gometalinter "gosimple" check, improve build.go

cmd/stcli/cmd_general.go

@@ -62,9 +62,9 @@ func generalID(c *cli.Context) {
 
 func generalStatus(c *cli.Context) {
 	response := httpGet(c, "system/config/insync")
-	status := make(map[string]interface{})
+	var status struct{ ConfigInSync bool }
 	json.Unmarshal(responseToBArray(response), &status)
-	if status["configInSync"] != true {
+	if !status.ConfigInSync {
 		die("Config out of sync")
 	}
 	fmt.Println("Config in sync")

cmd/stgenfiles/main.go

@@ -85,12 +85,7 @@ func generateOneFile(fd io.ReadSeeker, p1 string, s int64) error {
 	_ = os.Chmod(p1, os.FileMode(rand.Intn(0777)|0400))
 
 	t := time.Now().Add(-time.Duration(rand.Intn(30*86400)) * time.Second)
-	err = os.Chtimes(p1, t, t)
-	if err != nil {
-		return err
-	}
-
-	return nil
+	return os.Chtimes(p1, t, t)
 }
 
 func randomName() string {

cmd/syncthing/gui.go

@@ -381,10 +381,8 @@ func (s *apiService) String() string {
 }
 
 func (s *apiService) VerifyConfiguration(from, to config.Configuration) error {
-	if _, err := net.ResolveTCPAddr("tcp", to.GUI.Address()); err != nil {
-		return err
-	}
-	return nil
+	_, err := net.ResolveTCPAddr("tcp", to.GUI.Address())
+	return err
 }
 
 func (s *apiService) CommitConfiguration(from, to config.Configuration) bool {