build: Enable gometalinter "gosimple" check, improve build.go

2016-12-18 19:57:41 +01:00
parent 47f22ff3e5
commit d41c131364
19 changed files with 108 additions and 130 deletions
--- a/lib/protocol/hello.go
+++ b/lib/protocol/hello.go
@@ -105,11 +105,7 @@ func readHello(c io.Reader) (HelloResult, error) {
 		if err := hello.UnmarshalXDR(buf); err != nil {
 			return HelloResult{}, err
 		}
-		res := HelloResult{
-			DeviceName:    hello.DeviceName,
-			ClientName:    hello.ClientName,
-			ClientVersion: hello.ClientVersion,
-		}
+		res := HelloResult(hello)
 		return res, ErrTooOldVersion13

 	case 0x00010001, 0x00010000: