Must not call hex.Dump in non-debug mode...

2015-10-27 10:27:18 +01:00
parent 2b6a6b91f3
commit e3c0fba34b
2 changed files with 10 additions and 4 deletions
--- a/lib/protocol/protocol.go
+++ b/lib/protocol/protocol.go
@@ -411,10 +411,12 @@ func (c *rawConnection) readMessage() (hdr header, msg encodable, err error) {
 		l.Debugf("decompressed to %d bytes", len(msgBuf))
 	}

-	if len(msgBuf) > 1024 {
-		l.Debugf("message data:\n%s", hex.Dump(msgBuf[:1024]))
-	} else {
-		l.Debugf("message data:\n%s", hex.Dump(msgBuf))
+	if shouldDebug() {
+		if len(msgBuf) > 1024 {
+			l.Debugf("message data:\n%s", hex.Dump(msgBuf[:1024]))
+		} else {
+			l.Debugf("message data:\n%s", hex.Dump(msgBuf))
+		}
 	}

 	// We check each returned error for the XDRError.IsEOF() method.