all: Propagate errors from NamespacedKV (#6203)

As foretold by the prophecy, "once the database refactor is merged, then
shall appear a request to propagate errors from the store known
throughout the land as the NamedspacedKV, and it shall be good".

lib/stats/device.go

@@ -28,24 +28,30 @@ func NewDeviceStatisticsReference(ldb *db.Lowlevel, device string) *DeviceStatis
 	}
 }
 
-func (s *DeviceStatisticsReference) GetLastSeen() time.Time {
-	t, ok := s.ns.Time("lastSeen")
-	if !ok {
+func (s *DeviceStatisticsReference) GetLastSeen() (time.Time, error) {
+	t, ok, err := s.ns.Time("lastSeen")
+	if err != nil {
+		return time.Time{}, err
+	} else if !ok {
 		// The default here is 1970-01-01 as opposed to the default
 		// time.Time{} from s.ns
-		return time.Unix(0, 0)
+		return time.Unix(0, 0), nil
 	}
 	l.Debugln("stats.DeviceStatisticsReference.GetLastSeen:", s.device, t)
-	return t
+	return t, nil
 }
 
-func (s *DeviceStatisticsReference) WasSeen() {
+func (s *DeviceStatisticsReference) WasSeen() error {
 	l.Debugln("stats.DeviceStatisticsReference.WasSeen:", s.device)
-	s.ns.PutTime("lastSeen", time.Now())
+	return s.ns.PutTime("lastSeen", time.Now())
 }
 
-func (s *DeviceStatisticsReference) GetStatistics() DeviceStatistics {
-	return DeviceStatistics{
-		LastSeen: s.GetLastSeen(),
+func (s *DeviceStatisticsReference) GetStatistics() (DeviceStatistics, error) {
+	lastSeen, err := s.GetLastSeen()
+	if err != nil {
+		return DeviceStatistics{}, err
 	}
+	return DeviceStatistics{
+		LastSeen: lastSeen,
+	}, nil
 }

lib/stats/folder.go

@@ -35,45 +35,69 @@ func NewFolderStatisticsReference(ldb *db.Lowlevel, folder string) *FolderStatis
 	}
 }
 
-func (s *FolderStatisticsReference) GetLastFile() LastFile {
-	at, ok := s.ns.Time("lastFileAt")
-	if !ok {
-		return LastFile{}
+func (s *FolderStatisticsReference) GetLastFile() (LastFile, error) {
+	at, ok, err := s.ns.Time("lastFileAt")
+	if err != nil {
+		return LastFile{}, err
+	} else if !ok {
+		return LastFile{}, nil
 	}
-	file, ok := s.ns.String("lastFileName")
-	if !ok {
-		return LastFile{}
+	file, ok, err := s.ns.String("lastFileName")
+	if err != nil {
+		return LastFile{}, err
+	} else if !ok {
+		return LastFile{}, nil
+	}
+	deleted, _, err := s.ns.Bool("lastFileDeleted")
+	if err != nil {
+		return LastFile{}, err
 	}
-	deleted, _ := s.ns.Bool("lastFileDeleted")
 	return LastFile{
 		At:       at,
 		Filename: file,
 		Deleted:  deleted,
-	}
+	}, nil
 }
 
-func (s *FolderStatisticsReference) ReceivedFile(file string, deleted bool) {
+func (s *FolderStatisticsReference) ReceivedFile(file string, deleted bool) error {
 	l.Debugln("stats.FolderStatisticsReference.ReceivedFile:", s.folder, file)
-	s.ns.PutTime("lastFileAt", time.Now())
-	s.ns.PutString("lastFileName", file)
-	s.ns.PutBool("lastFileDeleted", deleted)
-}
-
-func (s *FolderStatisticsReference) ScanCompleted() {
-	s.ns.PutTime("lastScan", time.Now())
-}
-
-func (s *FolderStatisticsReference) GetLastScanTime() time.Time {
-	lastScan, ok := s.ns.Time("lastScan")
-	if !ok {
-		return time.Time{}
+	if err := s.ns.PutTime("lastFileAt", time.Now()); err != nil {
+		return err
 	}
-	return lastScan
+	if err := s.ns.PutString("lastFileName", file); err != nil {
+		return err
+	}
+	if err := s.ns.PutBool("lastFileDeleted", deleted); err != nil {
+		return err
+	}
+	return nil
 }
 
-func (s *FolderStatisticsReference) GetStatistics() FolderStatistics {
+func (s *FolderStatisticsReference) ScanCompleted() error {
+	return s.ns.PutTime("lastScan", time.Now())
+}
+
+func (s *FolderStatisticsReference) GetLastScanTime() (time.Time, error) {
+	lastScan, ok, err := s.ns.Time("lastScan")
+	if err != nil {
+		return time.Time{}, err
+	} else if !ok {
+		return time.Time{}, nil
+	}
+	return lastScan, nil
+}
+
+func (s *FolderStatisticsReference) GetStatistics() (FolderStatistics, error) {
+	lastFile, err := s.GetLastFile()
+	if err != nil {
+		return FolderStatistics{}, err
+	}
+	lastScanTime, err := s.GetLastScanTime()
+	if err != nil {
+		return FolderStatistics{}, err
+	}
 	return FolderStatistics{
-		LastFile: s.GetLastFile(),
-		LastScan: s.GetLastScanTime(),
-	}
+		LastFile: lastFile,
+		LastScan: lastScanTime,
+	}, nil
 }