perso/syncthing-arm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #1164 from syncthing/ro-tempfiles

Browse Source 
Handle read only temp files after crash/restart
This commit is contained in:
Audrius Butkevicius 2014-12-31 12:08:37 +00:00
commit e94bd90782
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
internal/model/sharedpullerstate.go
View File

@ -110,6 +110,17 @@ func (s *sharedPullerState) tempFile() (io.WriterAt, error) {
flags := os.O_WRONLY flags := os.O_WRONLY
if s.reused == 0 { if s.reused == 0 {
flags |= os.O_CREATE | os.O_EXCL flags |= os.O_CREATE | os.O_EXCL
} else {
// With sufficiently bad luck when exiting or crashing, we may have
// had time to chmod the temp file to read only state but not yet
// moved it to it's final name. This leaves us with a read only temp
// file that we're going to try to reuse. To handle that, we need to
// make sure we have write permissions on the file before opening it.
err := os.Chmod(s.tempName, 0644)
if err != nil {
s.earlyCloseLocked("dst create chmod", err)
return nil, err
}
} }
fd, err := os.OpenFile(s.tempName, flags, 0644) fd, err := os.OpenFile(s.tempName, flags, 0644)
if err != nil { if err != nil {