2111386ee4
I'm working through linter complaints, these are some fixes. Broad categories: 1) Ignore errors where we can ignore errors: add "_ = ..." construct. you can argue that this is annoying noise, but apart from silencing the linter it *does* serve the purpose of highlighting that an error is being ignored. I think this is OK, because the linter highlighted some error cases I wasn't aware of (starting CPU profiles, for example). 2) Untyped constants where we though we had set the type. 3) A real bug where we ineffectually assigned to a shadowed err. 4) Some dead code removed. There'll be more of these, because not all packages are fixed, but the diff was already large enough.
70 lines
1.6 KiB
Go
70 lines
1.6 KiB
Go
// Copyright (C) 2015 The Syncthing Authors.
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"io"
|
|
|
|
"github.com/syncthing/syncthing/lib/events"
|
|
)
|
|
|
|
// The auditService subscribes to events and writes these in JSON format, one
|
|
// event per line, to the specified writer.
|
|
type auditService struct {
|
|
w io.Writer // audit destination
|
|
stop chan struct{} // signals time to stop
|
|
started chan struct{} // signals startup complete
|
|
stopped chan struct{} // signals stop complete
|
|
}
|
|
|
|
func newAuditService(w io.Writer) *auditService {
|
|
return &auditService{
|
|
w: w,
|
|
stop: make(chan struct{}),
|
|
started: make(chan struct{}),
|
|
stopped: make(chan struct{}),
|
|
}
|
|
}
|
|
|
|
// Serve runs the audit service.
|
|
func (s *auditService) Serve() {
|
|
defer close(s.stopped)
|
|
sub := events.Default.Subscribe(events.AllEvents)
|
|
defer events.Default.Unsubscribe(sub)
|
|
enc := json.NewEncoder(s.w)
|
|
|
|
// We're ready to start processing events.
|
|
close(s.started)
|
|
|
|
for {
|
|
select {
|
|
case ev := <-sub.C():
|
|
_ = enc.Encode(ev)
|
|
case <-s.stop:
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
// Stop stops the audit service.
|
|
func (s *auditService) Stop() {
|
|
close(s.stop)
|
|
}
|
|
|
|
// WaitForStart returns once the audit service is ready to receive events, or
|
|
// immediately if it's already running.
|
|
func (s *auditService) WaitForStart() {
|
|
<-s.started
|
|
}
|
|
|
|
// WaitForStop returns once the audit service has stopped.
|
|
// (Needed by the tests.)
|
|
func (s *auditService) WaitForStop() {
|
|
<-s.stopped
|
|
}
|