web/cryptpad
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

validate owners against amended metadata when clearing channels

Browse Source
This commit is contained in:
ansuz 2019-08-21 12:41:00 +02:00
parent 8c92d3dc02
commit 31f7c4b90a
1 changed files with 2 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
rpc.js
View File

@ -330,16 +330,6 @@ var getMetadata = function (Env, channel, cb) {
} }
cb(void 0, ref.meta); cb(void 0, ref.meta);
}); });
/*
// FIXME METADATA
return void Env.msgStore.getChannelMetadata(channel, function (e, data) {
if (e) {
if (e.code === 'INVALID_METADATA') { return void cb(void 0, {}); }
return void cb(e.code);
}
cb(void 0, data);
});*/
}; };
var getMultipleFileSize = function (Env, channels, cb) { var getMultipleFileSize = function (Env, channels, cb) {
@ -813,20 +803,13 @@ var clearOwnedChannel = function (Env, channelId, unsafeKey, cb) {
return cb('INVALID_ARGUMENTS'); return cb('INVALID_ARGUMENTS');
} }
// FIXME METADATA getMetadata(Env, channelId, function (err, metadata) {
if (!(Env.msgStore && Env.msgStore.getChannelMetadata)) { if (err) { return void cb(err); }
return cb('E_NOT_IMPLEMENTED');
}
// FIXME METADATA
Env.msgStore.getChannelMetadata(channelId, function (e, metadata) {
if (e) { return cb(e); }
if (!(metadata && Array.isArray(metadata.owners))) { return void cb('E_NO_OWNERS'); } if (!(metadata && Array.isArray(metadata.owners))) { return void cb('E_NO_OWNERS'); }
// Confirm that the channel is owned by the user in question // Confirm that the channel is owned by the user in question
if (metadata.owners.indexOf(unsafeKey) === -1) { if (metadata.owners.indexOf(unsafeKey) === -1) {
return void cb('INSUFFICIENT_PERMISSIONS'); return void cb('INSUFFICIENT_PERMISSIONS');
} }
// FIXME COLDSTORAGE // FIXME COLDSTORAGE
return void Env.msgStore.clearChannel(channelId, function (e) { return void Env.msgStore.clearChannel(channelId, function (e) {
cb(e); cb(e);