web/cryptpad
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

add a note about handling syntax errors in mermaid

Browse Source
This commit is contained in:
ansuz 2020-04-14 15:18:20 -04:00
parent ca2dc85b34
commit 9a7681dc5d
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
www/common/diffMarked.js
View File

@ -360,6 +360,12 @@ define([
// retrieve the attached source code which it was drawn // retrieve the attached source code which it was drawn
var src = el.getAttribute('mermaid-source'); var src = el.getAttribute('mermaid-source');
/* The new source might have syntax errors that will prevent rendering.
It might be preferable to keep the existing state instead of removing it
if you don't have something better to display. Ideally we should display
the cause of the syntax error so that the user knows what to correct. */
//if (!Mermaid.parse(src)) { } // TODO
// check if that source exists in the set of charts which are about to be rendered // check if that source exists in the set of charts which are about to be rendered
if (mermaid_source.indexOf(src) === -1) { if (mermaid_source.indexOf(src) === -1) {
// if it's not, then you can remove it // if it's not, then you can remove it