Merge branch 'staging' of github.com:xwiki-labs/cryptpad into staging

www/common/cryptpad-common.js

@@ -574,7 +574,7 @@ define([
 
             if (!contains) {
                 var data = makePad(href, name);
-                getStore().pushData(data, function (e, state) {
+                getStore().pushData(data, function (e) {
                     if (e) {
                         if (e === 'E_OVER_LIMIT') {
                             common.alert(Messages.pinLimitNotPinned, null, true);
@@ -725,6 +725,7 @@ define([
     };
 
     var isOverPinLimit = common.isOverPinLimit = function (cb) {
+        if (!common.isLoggedIn()) { return void cb(null, false); }
         var usage;
         var andThen = function (e, limit) {
             if (e) { return void cb(e); }

www/common/toolbar.js

@@ -538,7 +538,7 @@ define([
         // User dropdown
         if (config.displayed.indexOf('useradmin') !== -1) {
             var userMenuCfg = {};
-            if (config.userData) {
+            if (!config.hideDisplayName) {
                 userMenuCfg = {
                     displayNameCls: USERNAME_CLS,
                     changeNameButtonCls: USERBUTTON_CLS,

www/common/userObject.js

@@ -434,7 +434,7 @@ define([
                 files[FILES_DATA].push(data);
                 cb();
             };
-            if (!Cryptpad.isLoggedIn() || !AppConfig.enablePinning) { todo(); }
+            if (!Cryptpad.isLoggedIn() || !AppConfig.enablePinning) { return void todo(); }
             Cryptpad.pinPads([Cryptpad.hrefToHexChannelId(data.href)], function (e, hash) {
                 if (e) { return void cb(e); }
                 todo();