Simon Frei and GitHub
534f07d9ca
lib/discover: Don't leak goroutines ( #5950 )
2019-08-22 12:30:57 +02:00
Simon Frei and GitHub
2d124e053c
test: Get integration tests up to speed (config, build and test fixes) ( #5962 )
2019-08-20 10:17:11 +02:00
Simon Frei and Jakob Borg
77a5980747
lib/model: Do free disk space check later on pull ( fixes #5948 ) ( #5949 )
2019-08-16 09:40:53 +02:00
Simon Frei and Jakob Borg
b677464dfa
lib/model: Optimise locking around conn-close and puller states ( #5954 )
2019-08-16 09:35:19 +02:00
Simon Frei and GitHub
b1c74860e8
all: Remove global events.Default (ref #4085 ) ( #5886 )
2019-08-15 16:29:37 +02:00
Simon Frei and Jakob Borg
f6f696c6c5
lib/config: Prevent nil deref in debug logging ( fixes #5955 ) ( #5956 )
2019-08-15 15:51:09 +02:00
Simon Frei and Jakob Borg
cf40ed6cec
lib/connections: Return exported intf from exported function ( #5947 )
2019-08-13 09:33:33 +02:00
Simon Frei and Jakob Borg
6fa02d5081
lib/model: Fix a few more problematic locks (ref #5929 ) ( #5944 )
2019-08-13 09:04:43 +02:00
Simon Frei and Jakob Borg
86e35f1879
lib/model: Less locking in ClusterConfig ( #5943 )
2019-08-11 19:30:24 +02:00
Simon Frei and Jakob Borg
4a619e74f2
lib/model: Fix incorrect locking ( #5939 )
2019-08-11 16:10:30 +02:00
Simon Frei and Jakob Borg
1475c0344a
gui: Parse strings before copying options object ( fixes #5824 ) ( #5922 )
2019-08-02 12:46:27 +02:00
Simon Frei and Jakob Borg
77cc87dfca
lib/connections: Log errors in relay clients ( #5917 )
2019-08-01 17:37:58 +02:00
Simon Frei and Jakob Borg
8a06cf0973
lib/model: Unflake TestPullInvalidIgnored ( #5918 )
2019-08-01 11:07:41 +02:00
Simon Frei and Jakob Borg
05835ed81f
all: Remove potentially problematic errors from panics ( fixes #5839 ) ( #5912 )
2019-07-31 10:53:35 +02:00
Simon Frei and Jakob Borg
df522576ac
lib/model: Don't call t.Fatal in goroutines ( fixes #5901 ) ( #5903 )
2019-07-30 17:50:51 +02:00
Simon Frei and GitHub
d681ac11fe
lib/config: Handle empty Fstype for mtime-window ( #5906 )
2019-07-30 15:23:00 +02:00
Simon Frei and Jakob Borg
7d5f7d508d
lib/syncthing: Stop only once ( fixes #5908 ) ( #5909 )
2019-07-29 20:07:19 +02:00
Simon Frei and Jakob Borg
1d182e4631
lib/fs: Use gopsutils for disk usage ( #5905 )
2019-07-29 20:06:17 +02:00
Simon Frei and Jakob Borg
710f5c199f
lib/db: Don't use global fileset in benchmarks ( #5902 )
2019-07-28 22:31:24 +02:00
Simon Frei and Jakob Borg
fd847d4efe
lib/model: Fix flakyness of TestRequestRemoteRenameChanged ( #5904 )
2019-07-28 22:29:31 +02:00
Simon Frei and Jakob Borg
dd850f66bb
lib/api: Close server before exiting serve ( fixes #5866 ) ( #5895 )
2019-07-28 08:03:55 +02:00
Simon Frei and GitHub
46e72d76b5
cmd/syncthing, lib/syncthing: Create library utils (ref #4085 ) ( #5871 )
2019-07-23 23:39:20 +02:00
Simon Frei and Jakob Borg
7a4c88d4e4
lib: Add mtime window when comparing files ( #5852 )
2019-07-23 21:48:53 +02:00
Simon Frei and Jakob Borg
35f40e9a58
lib/model: Create new file-set after stopping folder ( fixes #5882 ) ( #5883 )
2019-07-23 20:39:25 +02:00
Simon Frei and GitHub
5de9b677c2
lib/fs: Fix kqueue event list ( fixes #5308 ) ( #5885 )
2019-07-23 14:11:15 +02:00
Simon Frei and GitHub
6f08162376
lib/model: Remove incorrect/useless panics ( #5881 )
2019-07-23 10:51:16 +02:00
Simon Frei and GitHub
7b3d9a8dca
lib/syncthing: Refactor to use util.AsService ( #5858 )
2019-07-23 10:50:37 +02:00
Simon Frei and GitHub
942659fb06
lib/model, lib/nat: More service termination speedup ( #5884 )
2019-07-23 10:49:22 +02:00
Simon Frei and Jakob Borg
b5b54ff057
lib/model: No watch-error on missing folder ( fixes #5833 ) ( #5876 )
2019-07-19 19:41:16 +02:00
Simon Frei and Jakob Borg
4d3432af3e
lib: Ensure timely service termination ( fixes #5860 ) ( #5863 )
2019-07-19 19:40:40 +02:00
Simon Frei and Jakob Borg
1cb55904bc
lib/model: Prevent panic in NeedFolderFiles ( fixes #5872 ) ( #5875 )
2019-07-19 19:39:52 +02:00
Simon Frei and Jakob Borg
2b622d0774
lib/model: Close conn on dev pause ( fixes #5873 ) ( #5874 )
2019-07-19 19:37:29 +02:00
Simon Frei and Jakob Borg
1894123d3c
lib/syncthing: Modify exit status before stopping ( fixes #5869 ) ( #5870 )
2019-07-18 20:49:00 +02:00
Simon Frei and Jakob Borg
eed1edcca0
cmd/syncthing: Ensure myID is set by making it local ( fixes #5859 ) ( #5862 )
2019-07-17 07:19:14 +02:00
Simon Frei and Audrius Butkevicius
0025e9ccfb
all: Refactor cmd/syncthing creating lib/syncthing (ref #4085 ) ( #5805 )
...
* add skeleton for lib/syncthing
* copy syncthingMain to lib/syncthing (verbatim)
* Remove code to deduplicate copies of syncthingMain
* fix simple build errors
* move stuff from main to syncthing with minimal mod
* merge runtime options
* actually use syncthing.App
* pass io.writer to lib/syncthing for auditing
* get rid of env stuff in lib/syncthing
* add .Error() and comments
* review: Remove fs interactions from lib
* and go 1.13 happened
* utility functions
2019-07-14 11:43:13 +01:00
Simon Frei and Jakob Borg
82b70b9fae
lib/model, lib/protocol: Track closing connections ( fixes #5828 ) ( #5829 )
2019-07-14 11:03:55 +02:00
Simon Frei and Jakob Borg
def4b8cee5
lib/config: Error on empty folder path ( fixes #5853 ) ( #5854 )
2019-07-14 11:03:14 +02:00
Simon Frei and Jakob Borg
20c8dbd9ed
lib/model: Fix integer conversion ( fixes #5837 ) ( #5851 )
2019-07-12 16:37:12 +02:00
Simon Frei and Jakob Borg
3446d50201
lib/model: Remove pointless error that watch hasn't started ( fixes #5833 ) ( #5834 )
2019-07-10 11:00:06 +02:00
Simon Frei and Jakob Borg
9fef1552fc
lib/db, lib/model: Remove folder info from panics (ref #5839 ) ( #5840 )
2019-07-10 10:57:49 +02:00
Simon Frei and Audrius Butkevicius
85318f3b82
gui: On update setting don't show RC msg when disabled ( fixes #5803 ) ( #5842 )
2019-07-09 22:30:22 +01:00
Simon Frei and Audrius Butkevicius
485acda63b
lib/relay: Call the proper Error method (ref #5806 ) ( #5841 )
2019-07-09 22:29:19 +01:00
Simon Frei and Audrius Butkevicius
05e9e0bfa9
build: Update notify dependency ( #5838 )
2019-07-09 21:33:22 +01:00
Simon Frei and GitHub
ba056578ec
lib: Add util.Service as suture.Service template ( fixes #5801 ) ( #5806 )
2019-07-09 11:40:30 +02:00
Simon Frei and Jakob Borg
4cba433852
build: Add go major version to go.mod ( #5822 )
2019-06-30 13:18:34 +02:00
Simon Frei and Jakob Borg
863fe23347
gui, lib/model: Fix download progress accounting ( fixes #5811 ) ( #5815 )
2019-06-30 09:23:47 +02:00
Simon Frei and Jakob Borg
1cf352a722
lib/model: NewFileSet outside fmut ( #5818 )
2019-06-29 08:49:30 +02:00
Simon Frei and Jakob Borg
b58f6ca886
lib/model: Correct/unify check if item changed ( #5819 )
2019-06-29 07:45:41 +02:00
Simon Frei and Audrius Butkevicius
3c7e7e971d
lib/model: Make jobQueue.Jobs paginated ( fixes #5754 ) ( #5804 )
...
* lib/model: Make jobQueue.Jobs paginated (fixes #5754 )
* fix, no test yet
* add test
2019-06-27 19:25:38 +01:00
Simon Frei and Jakob Borg
bf744ded31
cmd/syncthing, lib/db: Exit/close db faster ( fixes #5781 ) ( #5782 )
...
This adds a 10s timeout on closing the db and additionally cancels active
db iterators and waits for them to terminate before closing the db.
2019-06-17 15:27:25 +03:00
Simon Frei and Jakob Borg
cea5962417
lib/model: Unflake TestPullInvalidIgnoredSR/SO ( fixes #5796 ) ( #5799 )
2019-06-17 15:23:28 +03:00
Simon Frei and Jakob Borg
02752af862
lib/protocol: Don't block on Close ( fixes #5794 ) ( #5795 )
2019-06-14 19:04:41 +02:00
Simon Frei and Jakob Borg
6b1d7ac727
gui: Check data before calling .reverse() ( #5793 )
2019-06-14 13:14:15 +02:00
Simon Frei and GitHub
abd363e8bb
lib/model: Don't error on pulling deletion of invalid file ( fixes #5791 ) ( #5792 )
2019-06-14 08:48:14 +02:00
Simon Frei and GitHub
38302270d4
build: Include cross-package test coverage ( #5735 )
2019-06-13 19:28:14 +02:00
Simon Frei and Jakob Borg
13a746e0fb
lib/model: Prevent nil deref if folder stopped ( fixes #5780 ) ( #5778 )
2019-06-11 11:48:51 +02:00
Simon Frei and GitHub
1054ce9354
lib/model: Refactor sending indexes as suture service ( #5757 )
2019-06-10 13:27:22 +02:00
Simon Frei and GitHub
97ad575b1f
gui: Enable rescan button with failed items ( fixes #5770 ) ( #5771 )
2019-06-10 10:12:30 +02:00
Simon Frei and Jakob Borg
5541697d18
gui: Don't call API when no modal is open ( fixes #5652 ) ( #5759 )
2019-06-05 14:03:52 +08:00
Simon Frei and Jakob Borg
e39d3f95dd
lib/protocol: Prioritize close msg and add close timeout ( #5746 )
2019-06-05 14:01:59 +08:00
Simon Frei and Jakob Borg
6664e01acf
lib/protocol: Return from ClusterConfig when closed ( #5752 )
2019-05-29 12:14:00 +02:00
Simon Frei and Audrius Butkevicius
3775a64d5c
lib/protocol: Don't send anything else before cluster config ( #5741 )
2019-05-27 11:15:34 +01:00
Simon Frei and Audrius Butkevicius
129df0613b
lib/model: Unflake folder restart with blocking conn test (ref #5707 ) ( #5744 )
2019-05-27 10:58:09 +01:00
Simon Frei and Audrius Butkevicius
486230768e
lib/fs, lib/model: Add error channel to Watch to avoid panics ( fixes #5697 ) ( #5734 )
...
* lib/fs, lib/model: Add error channel to Watch to avoid panics (fixes #5697 )
* forgot unsupported watch
* and more non(-standard)-unixy fixes
* and windows test
* review
2019-05-25 20:08:26 +01:00
Simon Frei and Audrius Butkevicius
9e6db72535
lib/protocol: Don't call receiver after calling Closed ( fixes #4170 ) ( #5742 )
...
* lib/protocol: Don't call receiver after calling Closed (fixes #4170 )
* review
2019-05-25 20:08:07 +01:00
Simon Frei and Audrius Butkevicius
d91da8feee
lib/model: Readd special handling of conn close in TestIssue5063 ( #5743 )
...
This partially reverts commit 64518b0f7e .
2019-05-25 18:51:13 +01:00
Simon Frei and GitHub
64518b0f7e
lib/model: Close connections when model is stopped ( #5733 )
2019-05-25 16:00:32 +02:00
Simon Frei and Audrius Butkevicius
5d35b2c540
lib/protocol: Test for Close on blocking send deadlock (ref #5442 ) ( #5732 )
2019-05-23 21:42:02 +01:00
Simon Frei and GitHub
5b306510a0
lib/model: Consistently cleanup model in tests ( #5724 )
2019-05-19 14:29:07 +02:00
Simon Frei and Jakob Borg
1b2b970f32
lib/model, lib/testutils: Test closing a connection on folder restart ( #5707 )
2019-05-18 08:53:59 +02:00
Simon Frei and Jakob Borg
5ffbb7668d
lib/model: Fix test flakyness regression (ref #5592 ) ( #5718 )
2019-05-18 08:52:50 +02:00
Simon Frei and Jakob Borg
1df8701c46
test: Report time per MiB on transfer benchs ( #5711 )
2019-05-18 08:46:08 +02:00
Simon Frei and GitHub
441ea109a1
lib/model: Refactor file deletions when pulling ( #5699 )
2019-05-17 18:29:54 +02:00
Simon Frei and Jakob Borg
dfbbb286fc
lib/fs: Consider win83 for root path as well when watching (ref #5706 ) ( #5709 )
2019-05-11 10:06:04 +02:00
Simon Frei and Jakob Borg
fbd445fe0a
lib/api: Clean up after test, enables test caching ( #5710 )
2019-05-11 08:41:32 +02:00
Simon Frei and GitHub
2b246eeb52
lib/model: Move test utilities to separate files ( #5694 )
2019-05-10 13:33:45 +02:00
Simon Frei and Jakob Borg
2558b021e5
lib/fs: Remove \\?\ for drive letters when watching ( fixes #5578 ) ( #5701 )
2019-05-10 09:09:58 +02:00
Simon Frei and Jakob Borg
283f39ae5f
lib/protocol: Revert unreleased changes related to closing connections ( #5688 )
...
This reverts commits:
ec7c88ca55
19b51c9b92
5da41f75fa
04b927104f
2019-05-08 08:08:26 +02:00
Simon Frei and Jakob Borg
b45d77b6be
lib/model: Fix regression deleting directories on pull (ref #5690 ) ( #5691 )
2019-05-06 20:55:26 +02:00
Simon Frei and Jakob Borg
79e67b7f79
lib/model: Remove individual pull errors on retry ( fixes #5659 ) ( #5690 )
2019-05-06 17:21:56 +02:00
Simon Frei and Audrius Butkevicius
5fa8467756
lib/model: Consistent use of locks ( #5684 )
2019-05-02 18:55:39 +01:00
Simon Frei and GitHub
5954b105cd
lib/model: Let fakeConnection call Model.Closed on close ( #5682 )
2019-05-02 14:24:55 +02:00
Simon Frei and GitHub
defc5dca65
lib/model: Use correct lock ( #5683 )
2019-05-02 14:09:42 +02:00
Simon Frei and GitHub
9f358ecae0
lib/protocol: Refactor to pass only relevant argument to writeMessage ( #5681 )
2019-05-02 14:09:19 +02:00
Simon Frei and GitHub
fe4daf242b
cmd, lib/db: Actually close goleveldb ( fixes #5505 ) ( #5671 )
2019-05-02 11:15:00 +02:00
Simon Frei and Audrius Butkevicius
ec7c88ca55
lib/protocol: Fix yet another deadlock ( fixes #5678 ) ( #5679 )
...
* lib/protocol: Fix yet another deadlock (fixes #5678 )
* more consistency
* read deadlock
* naming
* more naming
2019-05-02 09:21:07 +01:00
Simon Frei and Jakob Borg
19b51c9b92
lib/protocol: Don't close asyncMessage.done on success ( fixes #5674 ) ( #5675 )
2019-04-29 17:52:57 +02:00
Simon Frei and Audrius Butkevicius
5da41f75fa
lib/model, lib/protocol: Wait for reader/writer loops on close ( fixes #4170 ) ( #5657 )
...
* lib/protocol: Wait for reader/writer loops on close (fixes #4170 )
* waitgroup
* lib/model: Don't hold lock while closing connection
* fix comments
* review (lock once, func argument) and naming
2019-04-28 11:58:51 +01:00
Simon Frei and Audrius Butkevicius
04b927104f
lib/protocol: Don't send any messages before cluster config ( #5646 )
...
* lib/model: Send cluster config before releasing pmut
* reshuffle
* add model.connReady to track cluster-config status
* Corrected comments/strings
* do it in protocol
2019-04-23 20:47:11 +01:00
Simon Frei and Audrius Butkevicius
110806842c
lib/model: Pass the old not new fileinfo to deleteItemOnDisk ( fixes #5654 ) ( #5655 )
2019-04-23 20:46:28 +01:00
Simon Frei and GitHub
e302ccf4b4
lib/fs: Improve IsParent ( #5658 )
2019-04-22 11:12:32 +02:00
Simon Frei and Audrius Butkevicius
926e9228ed
lib/scanner, lib/model: File -> item when logging error ( #5664 )
2019-04-21 16:19:59 +01:00
Simon Frei and Audrius Butkevicius
86e72d9973
lib/model: Use RLock and legacy polish ( #5663 )
2019-04-21 13:21:36 +01:00
Simon Frei and GitHub
3bea59b0d9
lib/model: Refactor progressEmitter to de-/activate by config ( fixes #4613 ) ( #5623 )
2019-04-13 14:20:51 +02:00
Simon Frei and Jakob Borg
8a4b65b937
gui: Fix setting page size on failed and locally changed modals ( fixes #5421 ) ( #5650 )
2019-04-13 14:05:39 +02:00
Simon Frei and Jakob Borg
fca895a632
lib/model: Fix block index calculation for recheckFile ( fixes #5649 ) ( #5648 )
2019-04-12 15:21:07 +02:00
Simon Frei and GitHub
79360e2205
lib/fs: Add test that symlinks are skipped on walk ( #5644 )
2019-04-10 22:36:37 +02:00
Simon Frei and GitHub
9b2a73f9ab
lib/model: Pause pull for at least as long as failed pull took ( fixes #5641 ) ( #5643 )
2019-04-10 16:22:23 +02:00
Simon Frei and Jakob Borg
c305265c62
lib/model: Request errors conforming to BEP specs ( #5642 )
2019-04-10 11:47:24 +02:00
Simon Frei and GitHub
ca823bd591
lib/fs: When watching remove \\?\ for drive letters ( fixes #5578 ) ( #5633 )
2019-04-09 09:02:04 +02:00