Simon Frei and Audrius Butkevicius
22e133cce6
lib/db: Deduplicate comparing old and new items ( #5465 )
2019-01-18 21:19:56 +00:00
Simon Frei and Jakob Borg
1f87b874af
lib/db: Add "dirty" function terminology to getGlobal (ref #5462 ) ( #5463 )
2019-01-18 13:01:39 +01:00
Simon Frei and Jakob Borg
c87411851d
lib/protocol: Fix potential deadlock when closing connection (ref #5440 ) ( #5442 )
2019-01-14 08:32:37 +01:00
Simon Frei and Jakob Borg
51f65bd23a
lib/model: Reset pull errors when succeeding ( fix #5450 ) ( #5451 )
2019-01-14 08:30:52 +01:00
Simon Frei and Audrius Butkevicius
0b03b6a9ec
lib/model: Improve filesystem operations during tests ( fixes #5422 )
...
* lib/fs, lib/model: Improve filesystem operations during tests (fixes #5422 )
Introduces MustFilesystem that panics on errors and should be used for operations
during testing which must never fail.
Create temporary directories outside of testdata.
* don't do a filesystem, just a wrapper around os for testing
* fix copyright
2019-01-11 12:56:05 +00:00
Simon Frei and Jakob Borg
24ffd8be99
all: Send Close BEP msg on intentional disconnect ( #5440 )
...
This avoids waiting until next ping and timeout until the connection is actually
closed both by notifying the peer of the disconnect and by immediately closing
the local end of the connection after that. As a nice side effect, info level
logging about dropped connections now have the actual reason in it, not a generic
timeout error which looks like a real problem with the connection.
2019-01-09 17:31:09 +01:00
Simon Frei and Jakob Borg
158559023e
lib/db: Fix sequence updating for remote invalid items ( #5420 )
...
* lib/db: Fix sequence updating for remote invalid items
* fix for the unit test introduced in the previous commit
* lib/db: Polish blockmap
2019-01-04 20:19:10 +01:00
Simon Frei and Jakob Borg
47e08797cb
lib/model: Don't pull if ignores failed to load and cleanup ( #5418 )
2019-01-01 10:17:14 +01:00
Simon Frei and Jakob Borg
643cfe2e98
lib/config: Revert #5415 ( #5417 )
...
This reverts commit 9d075781ad#5415 )"
2018-12-30 21:57:41 +01:00
Simon Frei and Jakob Borg
8bb9878f26
lib/model: Check folder context before setting error state ( #5416 )
2018-12-30 21:56:16 +01:00
Simon Frei and Jakob Borg
4783294a09
lib/model: Don't pass nil *Matcher to performFinish ( fixes #5401 ) ( #5402 )
2018-12-22 21:58:17 +01:00
Simon Frei and Jakob Borg
99c9d65ddf
lib/scanner: Check ignore patterns before reporting error ( fixes #5397 ) ( #5398 )
2018-12-21 12:08:15 +01:00
Simon Frei and Jakob Borg
fc81e2b3d7
lib/model: Do folder watch operations under lock ( fixes #5392 ) ( #5395 )
2018-12-21 12:06:21 +01:00
Simon Frei and Jakob Borg
c3b3e02f21
test: Update configs and revert changes during testing ( #5393 )
2018-12-21 11:50:28 +01:00
Simon Frei and Jakob Borg
2626143fc5
lib/rc: Fix hangups when Syncthing process ends unexpectedly ( #5383 )
2018-12-21 11:49:04 +01:00
Simon Frei and Jakob Borg
3cc8918eb4
lib/db: Defer unlock to avoid hangup on panic ( #5388 )
2018-12-17 14:59:09 +01:00
Simon Frei and GitHub
c40c9a8d6a
lib/scanner: Don't report error on missing items ( fixes #5385 ) ( #5387 )
2018-12-17 14:52:15 +01:00
Simon Frei and Jakob Borg
c934918347
lib/scanner: Fix empty path on normalization error ( fixes #5369 ) ( #5370 )
2018-12-12 12:09:39 +01:00
Simon Frei and Jakob Borg
a09079ed25
all: Display list of locally changed items in UI ( fixes #5336 ) ( #5337 )
2018-12-11 09:59:04 +01:00
Simon Frei and GitHub
0391c57a37
cmd/syncthing: Improve logged device information on startup ( #5321 )
2018-11-22 11:39:01 +01:00
Simon Frei and Jakob Borg
2f9840ddae
lib: Introduce fs.IsParent ( fixes #5324 ) ( #5326 )
2018-11-22 11:16:45 +01:00
Simon Frei and Audrius Butkevicius
db8777c29e
lib/model: Add test for #5323 ( #5325 )
2018-11-13 08:36:16 +00:00
Simon Frei and Jakob Borg
33bed5b1ec
lib/model: Don't compare permissions if IgnorePerms is true ( fixes #5323 ) ( #5322 )
2018-11-13 08:54:49 +01:00
Simon Frei and Jakob Borg
4f27bdfc27
lib/model, lib/protocol: Handle request concurrency in model ( #5216 )
2018-11-13 08:53:55 +01:00
Simon Frei and Jakob Borg
603da2dce2
cmd/syncthing, lib/relay: Fixes regarding stopping of services ( #5293 )
2018-11-07 11:05:07 +01:00
Simon Frei and Jakob Borg
d510e3cca3
all: Display errors while scanning in web UI ( fixes #4480 ) ( #5215 )
2018-11-07 11:04:41 +01:00
Simon Frei and Jakob Borg
aec91d8f32
cmd/ursrv: Add google maps api key ( fixes #5296 ) ( #5303 )
2018-11-01 06:21:28 +01:00
Simon Frei and Jakob Borg
53b0f36be6
lib/fs: Use os.FileMode.String for fs.FileMode ( #5302 )
2018-10-31 12:49:50 +01:00
Simon Frei and Jakob Borg
01ade9c8ae
lib/connections: Don't panic on removed device ( fixes #5299 ) ( #5300 )
2018-10-30 10:34:19 +01:00
Simon Frei and Jakob Borg
b1acc37c16
lib/db: Update local need on device removal ( fixes #5294 ) ( #5295 )
2018-10-30 05:40:51 +01:00
Simon Frei and Audrius Butkevicius
64a591610b
lib/model: Check if files from queue are invalid ( fixes #5291 ) ( #5292 )
2018-10-26 19:13:35 +01:00
Simon Frei and GitHub
406bedf1e3
lib/logger: Disable debug flags without debugging ( fixes #4780 ) ( #5278 )
2018-10-23 15:17:40 +02:00
Simon Frei and Jakob Borg
7f55fbbe84
gui: Show usage reporting title regardless of RC ( #5284 )
2018-10-23 17:30:13 +09:00
Simon Frei and GitHub
c0be9987d0
build: Add desktop files and icons to .deb ( fixes #3439 ) ( #5277 )
2018-10-20 08:25:59 +02:00
Simon Frei and Jakob Borg
6325ae070c
cmd/syncthing: Correct type assertion in verboseService ( fixes #5270 ) ( #5272 )
2018-10-16 01:09:24 +02:00
Simon Frei and Audrius Butkevicius
089c283ca6
lib/config: Disable folder free disk check when configured ( fixes #5267 ) ( #5268 )
2018-10-12 12:34:56 +01:00
Simon Frei and Jakob Borg
8d7ea0424d
vendor: Update github.com/syncthing/notify ( #5263 )
2018-10-12 12:24:25 +02:00
Simon Frei and Jakob Borg
0690fe7585
lib/model: Unnecessary return ( #5264 )
2018-10-11 15:08:37 +02:00
Simon Frei and Jakob Borg
3e50edf46f
lib/db: More info in sequence panic msg ( #5261 )
2018-10-11 12:05:57 +02:00
Simon Frei and Jakob Borg
1b10607def
lib/model: Don't check folder health if there is nothing to pull ( fixes #2497 ) ( #5255 )
2018-10-11 11:33:21 +02:00
Simon Frei and Jakob Borg
d10773c311
lib/db, lib/model: Resolve identical recv only items ( fixes #5130 ) ( #5230 )
2018-10-10 12:43:07 +02:00
Simon Frei and Jakob Borg
523ac45456
lib/model: Treat failed rename like del&update ( #5203 )
2018-10-10 11:37:20 +02:00
Simon Frei and Jakob Borg
c9d6366d75
lib/connections: Don't info log about LAN if there are no rate limits ( #5242 )
2018-10-05 08:22:47 +02:00
Simon Frei and Jakob Borg
714a47ffb0
lib/config: Add context to the home disk out of space error ( #5241 )
2018-10-05 08:21:39 +02:00
Simon Frei and Jakob Borg
c2b0d309fb
lib/model: Prevent repeat db update ( #5231 )
2018-09-27 07:41:40 +02:00
Simon Frei and GitHub
cb0950b3fd
lib/db: Improve VersionList.String ( #5229 )
2018-09-26 23:30:22 +02:00
Simon Frei and Audrius Butkevicius
03d0f0dc34
lib/fs: Try EvalSymlinks without '\\?\' prefix on failure ( fixes #5226 ) ( #5227 )
2018-09-26 19:28:20 +01:00
Simon Frei and GitHub
4f4781d254
lib/scanner: Centralise protocol.FileInfo creation ( #5202 )
2018-09-18 15:34:17 +02:00
Simon Frei and GitHub
272fb3b444
all: Adjust windows perms in fs package ( #5200 )
2018-09-16 16:09:56 +02:00
Simon Frei and Audrius Butkevicius
60eb9088ff
lib/model: Extend shortcutFile ( #5201 )
2018-09-16 10:29:06 +01:00
Simon Frei and Jakob Borg
c8652222ef
all: Check files on disk/in db when deleting/renaming ( fixes #5194 ) ( #5195 )
2018-09-16 09:48:14 +02:00
Simon Frei and Jakob Borg
a57fa9cfab
lib/model: Polish ( #5189 )
2018-09-13 18:17:13 +02:00
Simon Frei and Audrius Butkevicius
49d5eae66a
lib/config: Actually modify config element ( fixes #5185 ) ( #5186 )
2018-09-12 12:16:52 +01:00
Simon Frei and Jakob Borg
50ba0fd079
lib/fs: Case insensitive conversion to rel path on windows ( fixes #5183 ) ( #5176 )
2018-09-11 22:30:32 +02:00
Simon Frei and Jakob Borg
0a29fa65ab
cmd/ursrv: Display more relevant data ( #17 )
2018-09-09 14:28:48 +02:00
Simon Frei and Jakob Borg
09aff7bb14
lib/model: Fixes on receive-only test setup and pulling ( #5136 )
2018-09-02 21:36:07 +02:00
Simon Frei and Jakob Borg
b068c8f346
lib/fs: Don't add path separators at end of path ( fixes #5144 ) ( #5146 )
2018-09-02 21:31:18 +02:00
Simon Frei and Jakob Borg
c2ff49ed43
lib/fs: Evaluate root when watching not on fs creation ( fixes #5043 ) ( #5105 )
2018-09-02 21:31:04 +02:00
Simon Frei and Jakob Borg
c62ce007ea
lib/fs: Don't add path separators at end of path ( fixes #5144 ) ( #5146 )
2018-08-28 08:18:55 +02:00
Simon Frei and Jakob Borg
03c0537340
lib/model: Fix regressions detecting deletes/ignores ( fixes #5125 , fixes #5127 ) ( #5129 )
2018-08-25 10:32:35 +02:00
Simon Frei and Jakob Borg
cb0f4ce55a
lib/model: Don't stop folder if out of disk space ( fixes #2370 ) ( #5099 )
...
This removes the out of disk space check from CheckHealth. The disk space is now
only checked if there are files to pull, in which case pulling those files is
stopped, but everything else (dirs, links, deletes) keeps running -> can recover
disk space through pulling.
2018-08-25 10:16:38 +02:00
Simon Frei and Audrius Butkevicius
165417c462
lib/model: Fixes on receive-only test setup and pulling ( #5136 )
2018-08-19 22:34:26 +01:00
Simon Frei and Audrius Butkevicius
ff3cbdc90d
lib/model: Check availability later to catch renames ( #5097 )
2018-08-19 19:03:20 +01:00
Simon Frei and GitHub
9028969617
lib/model: Small fixes to test convenience functions ( #5128 )
2018-08-16 12:11:48 +02:00
Simon Frei and Jakob Borg
7c0798b622
lib/model: Always release the lock ( #5126 )
2018-08-15 16:44:59 +02:00
Simon Frei and Jakob Borg
ee42c46bd3
lib/model: Catch racy nil deref in ClusterConfig ( #5106 )
2018-08-15 16:44:20 +02:00
Simon Frei and Jakob Borg
885f6fcf28
lib/model: Always release the lock ( #5126 )
2018-08-15 16:33:03 +02:00
Simon Frei and Jakob Borg
dc57bab107
lib/model: Don't enter pulling state if we need nothing ( fixes #4782 ) ( #5118 )
2018-08-13 20:39:25 +02:00
Simon Frei and GitHub
c55c0c8c28
lib/watchaggregator: Don't delay mixed events only ( #5094 )
...
Also fix a minor bug in testing failure output.
2018-08-13 09:14:03 +02:00
Simon Frei and Jakob Borg
e20679afe1
lib/fs: Evaluate root when watching not on fs creation ( fixes #5043 ) ( #5105 )
2018-08-11 22:24:36 +02:00
Simon Frei and Jakob Borg
dfe4008607
lib/model: Catch racy nil deref in ClusterConfig ( #5106 )
2018-08-11 09:10:29 +02:00
Simon Frei and Audrius Butkevicius
82c9e23206
vendor: Remove unused vendor packages ( fixes #3595 ) ( #5096 )
2018-08-04 16:29:13 +01:00
Simon Frei and Jakob Borg
705b7d18e8
build: Also copy gui to temporary GOPATH ( #5095 )
2018-08-02 16:13:17 +02:00
Simon Frei and Jakob Borg
f4bde023aa
build: Build and set GOPATH before generating assets ( #5093 )
2018-08-01 21:22:47 +02:00
Simon Frei and Audrius Butkevicius
5592b8b190
lib/model: Record error for unavailable files ( #5066 )
2018-07-14 14:09:23 +01:00
Simon Frei and Jakob Borg
6b82538e62
lib/model: Also handle missing parent dir non-regular items ( #5048 )
...
This is an improvement of PR #4493 and related to (and maybe fixing) #4961
and #4475 . Maybe fixing, because there is no clear reproducer for that
problem.
The previous PR added a mechanism to resurrect missing parent directories,
if there is a valid child file to be pulled. The same mechanism does not
exist for dirs and symlinks, even though a missing parent can happen for
those items as well. Therefore this PR extends the resurrection to all types
of pulled items.
In addition I moved the IsDeleted branch while iterating over
processDirectly to the existing IsDeleted branch in the WithNeed iteration.
This saves one pointless assignment and IsDeleted query. Also
2018-07-10 18:40:06 +03:00
Simon Frei and Jakob Borg
3f17bda786
lib/db: Catch unignored/conflicting files as needed ( fixes #5053 ) ( #5054 )
2018-07-10 18:32:34 +03:00
Simon Frei and Audrius Butkevicius
409cb2beb8
lib/fs: Catch size-preserving changes on windows ( fixes #5050 ) ( #5056 )
2018-07-09 18:29:22 +01:00
Simon Frei and Jakob Borg
742ab17a2a
authors: Patch xor-gate ( #5057 )
2018-07-09 16:22:51 +03:00
Simon Frei and Audrius Butkevicius
0f0290d574
lib/model, lib/weakhash: Abort pulling quicker on folder stop (ref #5028 )
2018-07-04 08:07:33 +01:00
Simon Frei and Jakob Borg
0631fd2440
vendor: Add missing file to github.com/syncthing/notify ( #5042 )
2018-07-04 08:37:58 +02:00
Simon Frei and Jakob Borg
b91ff430db
lib/model: Release both locks when waiting for services to stop ( fixes #5028 )
2018-06-28 13:29:41 +02:00
Simon Frei and Jakob Borg
881e923105
cmd/syncthing, lib/db: Abort execution if db version is too high ( fixes #4994 ) ( #5022 )
2018-06-26 11:40:34 +02:00
Simon Frei and Jakob Borg
406b394704
vendor: Update github.com/syncthing/notify ( fixes #4854 ) ( #5032 )
2018-06-26 10:13:39 +02:00
Simon Frei and Audrius Butkevicius
7b0d8c2e77
lib/model: Release both locks when waiting for services to stop ( fixes #5028 )
2018-06-24 16:55:28 +01:00
Simon Frei and GitHub
238476bfcd
gui: kiB -> KiB ( fixes #5017 ) ( #5021 )
2018-06-20 16:51:30 +02:00
Simon Frei and Jakob Borg
c2784d76e4
lib/db: Remove updated invalid files from need bucket ( fixes #5007 ) ( #5008 )
2018-06-18 08:23:40 +02:00
Simon Frei and Jakob Borg
8ff7ceeddc
lib/ignore, lib/scanner: Fix recursion to catch included paths ( fixes #5009 ) ( #5010 )
2018-06-18 08:22:19 +02:00
Simon Frei and Audrius Butkevicius
54e17c8bf4
lib/model: Don't set watch error on folder creation (fixes 5005) ( #5006 )
2018-06-15 23:33:23 +01:00
Simon Frei and Jakob Borg
9e0e04f4de
all: Fix FS watcher restarting and web UI indication ( fixes #4923 ) ( #4962 )
2018-06-11 15:47:54 +02:00
Simon Frei and GitHub
1e2732aa21
lib/config, lib/model: Don't warn and return error ( #4997 )
2018-06-10 15:41:20 +02:00
Simon Frei and GitHub
b7234785f8
lib/model: Wait for folder to stop ( fixes #4981 ) ( #4982 )
2018-06-10 13:24:59 +02:00
Simon Frei and Jakob Borg
30056cd1ae
lib/db: Move database schema migration into its own file ( #4985 )
2018-06-08 12:46:00 +02:00
Simon Frei and GitHub
e2c44f519c
lib/config, lib/model: Handle shared with information in config ( fixes #4870 ) ( #4974 )
2018-06-06 23:34:11 +02:00
Simon Frei and GitHub
53a029a796
gui: Restrict shown decimals and restrict size of header columns ( #4973 )
2018-06-06 23:33:31 +02:00
Simon Frei and GitHub
b670b5550a
gui: Don't remove the slash from path '/' ( fixes #4983 ) ( #4988 )
2018-06-05 23:47:47 +02:00
Simon Frei and GitHub
ee6516aa31
lib/fs: Resolve 8.3 filenames from watcher (ref #3800 ) ( #4975 )
2018-06-04 13:41:03 +02:00
Simon Frei and Jakob Borg
5baa432906
lib/db: Add index to track locally needed files ( #4958 )
...
To optimize WithNeed, which is called for the local device whenever an index
update is received. No tracking for remote devices to conserve db space, as
WithNeed is only queried for completion.
2018-06-02 15:08:32 +02:00
Simon Frei and Audrius Butkevicius
a83176c77a
lib/watchaggregator: Speedup propagation of removals ( fixes #4953 ) ( #4955 )
2018-05-26 10:08:23 +01:00
Simon Frei and Audrius Butkevicius
07bf24a3b4
lib/watchaggregator: Prevent race on config update ( #4938 )
2018-05-24 19:47:15 +01:00
