Simon Frei and Audrius Butkevicius
5592b8b190
lib/model: Record error for unavailable files ( #5066 )
2018-07-14 14:09:23 +01:00
Simon Frei and Jakob Borg
6b82538e62
lib/model: Also handle missing parent dir non-regular items ( #5048 )
...
This is an improvement of PR #4493 and related to (and maybe fixing) #4961
and #4475 . Maybe fixing, because there is no clear reproducer for that
problem.
The previous PR added a mechanism to resurrect missing parent directories,
if there is a valid child file to be pulled. The same mechanism does not
exist for dirs and symlinks, even though a missing parent can happen for
those items as well. Therefore this PR extends the resurrection to all types
of pulled items.
In addition I moved the IsDeleted branch while iterating over
processDirectly to the existing IsDeleted branch in the WithNeed iteration.
This saves one pointless assignment and IsDeleted query. Also
2018-07-10 18:40:06 +03:00
Simon Frei and Jakob Borg
3f17bda786
lib/db: Catch unignored/conflicting files as needed ( fixes #5053 ) ( #5054 )
2018-07-10 18:32:34 +03:00
Simon Frei and Audrius Butkevicius
409cb2beb8
lib/fs: Catch size-preserving changes on windows ( fixes #5050 ) ( #5056 )
2018-07-09 18:29:22 +01:00
Simon Frei and Jakob Borg
742ab17a2a
authors: Patch xor-gate ( #5057 )
2018-07-09 16:22:51 +03:00
Simon Frei and Audrius Butkevicius
0f0290d574
lib/model, lib/weakhash: Abort pulling quicker on folder stop (ref #5028 )
2018-07-04 08:07:33 +01:00
Simon Frei and Jakob Borg
0631fd2440
vendor: Add missing file to github.com/syncthing/notify ( #5042 )
2018-07-04 08:37:58 +02:00
Simon Frei and Jakob Borg
b91ff430db
lib/model: Release both locks when waiting for services to stop ( fixes #5028 )
2018-06-28 13:29:41 +02:00
Simon Frei and Jakob Borg
881e923105
cmd/syncthing, lib/db: Abort execution if db version is too high ( fixes #4994 ) ( #5022 )
2018-06-26 11:40:34 +02:00
Simon Frei and Jakob Borg
406b394704
vendor: Update github.com/syncthing/notify ( fixes #4854 ) ( #5032 )
2018-06-26 10:13:39 +02:00
Simon Frei and Audrius Butkevicius
7b0d8c2e77
lib/model: Release both locks when waiting for services to stop ( fixes #5028 )
2018-06-24 16:55:28 +01:00
Simon Frei and GitHub
238476bfcd
gui: kiB -> KiB ( fixes #5017 ) ( #5021 )
2018-06-20 16:51:30 +02:00
Simon Frei and Jakob Borg
c2784d76e4
lib/db: Remove updated invalid files from need bucket ( fixes #5007 ) ( #5008 )
2018-06-18 08:23:40 +02:00
Simon Frei and Jakob Borg
8ff7ceeddc
lib/ignore, lib/scanner: Fix recursion to catch included paths ( fixes #5009 ) ( #5010 )
2018-06-18 08:22:19 +02:00
Simon Frei and Audrius Butkevicius
54e17c8bf4
lib/model: Don't set watch error on folder creation (fixes 5005) ( #5006 )
2018-06-15 23:33:23 +01:00
Simon Frei and Jakob Borg
9e0e04f4de
all: Fix FS watcher restarting and web UI indication ( fixes #4923 ) ( #4962 )
2018-06-11 15:47:54 +02:00
Simon Frei and GitHub
1e2732aa21
lib/config, lib/model: Don't warn and return error ( #4997 )
2018-06-10 15:41:20 +02:00
Simon Frei and GitHub
b7234785f8
lib/model: Wait for folder to stop ( fixes #4981 ) ( #4982 )
2018-06-10 13:24:59 +02:00
Simon Frei and Jakob Borg
30056cd1ae
lib/db: Move database schema migration into its own file ( #4985 )
2018-06-08 12:46:00 +02:00
Simon Frei and GitHub
e2c44f519c
lib/config, lib/model: Handle shared with information in config ( fixes #4870 ) ( #4974 )
2018-06-06 23:34:11 +02:00
Simon Frei and GitHub
53a029a796
gui: Restrict shown decimals and restrict size of header columns ( #4973 )
2018-06-06 23:33:31 +02:00
Simon Frei and GitHub
b670b5550a
gui: Don't remove the slash from path '/' ( fixes #4983 ) ( #4988 )
2018-06-05 23:47:47 +02:00
Simon Frei and GitHub
ee6516aa31
lib/fs: Resolve 8.3 filenames from watcher (ref #3800 ) ( #4975 )
2018-06-04 13:41:03 +02:00
Simon Frei and Jakob Borg
5baa432906
lib/db: Add index to track locally needed files ( #4958 )
...
To optimize WithNeed, which is called for the local device whenever an index
update is received. No tracking for remote devices to conserve db space, as
WithNeed is only queried for completion.
2018-06-02 15:08:32 +02:00
Simon Frei and Audrius Butkevicius
a83176c77a
lib/watchaggregator: Speedup propagation of removals ( fixes #4953 ) ( #4955 )
2018-05-26 10:08:23 +01:00
Simon Frei and Audrius Butkevicius
07bf24a3b4
lib/watchaggregator: Prevent race on config update ( #4938 )
2018-05-24 19:47:15 +01:00
Simon Frei and GitHub
ef1633ac76
lib/db: Update global count when removing the previous global version ( #4968 )
2018-05-24 18:17:45 +02:00
Simon Frei and Jakob Borg
9f305f674a
gui: Check if folder exists in folderLabel ( fixes #4965 ) ( #4966 )
2018-05-23 12:41:04 +02:00
Simon Frei and Audrius Butkevicius
9d2b744c12
lib/model: Move String method to folder ( #4964 )
2018-05-23 08:23:21 +01:00
Simon Frei and Jakob Borg
d64d954721
lib/db: Fix prefixed walks ( fixes #4925 ) ( #4940 )
2018-05-17 09:26:40 +02:00
Simon Frei and Jakob Borg
81f9a81c7d
gui: Change rescan interval only if fs watcher was actually toggled ( fixes #4944 ) ( #4946 )
2018-05-17 09:21:10 +02:00
Simon Frei and Audrius Butkevicius
eabce48761
lib/model: Also wait for ItemFinished in TestDeregister ( #4951 )
2018-05-14 20:01:35 +01:00
Simon Frei and GitHub
d59aecba31
lib/ignore, lib/scanner: Catch included items below ignored ones ( #4811 )
2018-05-14 09:47:23 +02:00
Simon Frei and Jakob Borg
c4a348db67
gui: Fallback to folder ID in recent changes ( fixes #4947 ) ( #4949 )
2018-05-14 08:53:01 +02:00
Simon Frei and Jakob Borg
7d07b19734
gui: Fallback to folder ID in recent changes ( fixes #4947 ) ( #4949 )
2018-05-13 07:43:51 +02:00
Simon Frei and Jakob Borg
a7e30c925f
all: Use Executable from os instead of osext ( fixes #4900 ) ( #4950 )
2018-05-13 07:43:24 +02:00
Simon Frei and Jakob Borg
a2f51c85c2
lib/osutil: Add test for IsDeleted (ref #4925 ) ( #4936 )
2018-05-10 21:39:33 +02:00
Simon Frei and Jakob Borg
00f4900ba7
build: Increase test timeout to 2min ( #4937 )
2018-05-10 21:38:49 +02:00
Simon Frei and Jakob Borg
a94aceb22f
lib/model: Don't create folder root when paused ( fixes #4903 ) ( #4904 )
2018-05-05 10:30:39 +02:00
Simon Frei and Audrius Butkevicius
53dc346583
lib/model: Fix test function for introducer ( #4898 )
2018-05-01 22:56:20 +01:00
Simon Frei and Jakob Borg
a548014755
lib/db, lib/model: Add sequence->deviceKey to db for sending indexes ( #4906 )
...
Instead of walking and unmarshalling the entire db and sorting the resulting
file infos by sequence, add store device keys by sequence number in the
database. Thus only the required file infos need be unmarshalled and are already
sorted by index.
2018-05-01 23:39:15 +02:00
Simon Frei and Audrius Butkevicius
f6458d1b8f
lib/config, lib/model: Include paused folders in cluster config ( fixes #4897 )
2018-04-22 17:01:52 +01:00
Simon Frei and Jakob Borg
a1b5a3d5c0
vendor: Update github.com/syncthing/notify ( fixes #4885 ) ( #4894 )
2018-04-21 13:42:08 +02:00
Simon Frei and GitHub
3d02fcd473
vendor: Update github.com/syncthing/notify ( fixes #4885 ) ( #4894 )
2018-04-20 17:01:03 +02:00
Simon Frei and Jakob Borg
1f70f7e37c
lib/osutil: Fix TraversesSymlink with symlinked fs root on windows ( fixes #4875 ) ( #4886 )
2018-04-18 07:28:35 +02:00
Simon Frei and GitHub
eca076cf7d
lib/osutil: Fix TraversesSymlink with symlinked fs root on windows ( fixes #4875 ) ( #4886 )
2018-04-17 22:53:06 +02:00
Simon Frei and Jakob Borg
17e3608865
lib/fs: Fix watcher panic due to casing on windows ( fixes #4877 ) ( #4878 )
2018-04-16 20:10:11 +02:00
Simon Frei and Jakob Borg
01aef75c96
lib/fs: Fix watcher panic due to casing on windows ( fixes #4877 ) ( #4878 )
2018-04-16 20:07:00 +02:00
Simon Frei and Audrius Butkevicius
4072ae4d05
lib/model: Prevent warning on request in paused folder ( fixes #4870 )
2018-04-09 20:55:52 +01:00
Simon Frei and Audrius Butkevicius
26d87ec3bb
lib/fs: Don't panic when watching a folder with symlinked root ( #4846 )
2018-03-28 22:01:25 +01:00
Simon Frei and Jakob Borg
bea6ecaf35
lib/scanner, lib/model: Actually assign version when un-ignoring ( fixes #4841 ) ( #4842 )
...
This fixes a mistake introduced in #4750 and #4776 and is relevant to v0.14.46-rc1
2018-03-27 16:25:36 -04:00
Simon Frei and Jakob Borg
69f2c26d50
lib/scanner, lib/model: Actually assign version when un-ignoring ( fixes #4841 ) ( #4842 )
...
This fixes a mistake introduced in #4750 and #4776 and is relevant to v0.14.46-rc1
2018-03-27 16:24:20 -04:00
Simon Frei and Audrius Butkevicius
a557d62c4a
all: Transition to using fs watcher by default ( fixes #4552 )
2018-03-25 21:05:47 +01:00
Simon Frei and Jakob Borg
da3b38ccce
lib/fs: Fix and update error about inotify watch limit ( fixes #4833 ) ( #4835 )
2018-03-23 12:56:38 +01:00
Simon Frei and Audrius Butkevicius
81bd428b25
review & forgotten fixes from other PR
2018-03-18 01:10:13 +00:00
Simon Frei and Audrius Butkevicius
ae74ac8329
gui: Tabify edit folder modal
...
Copied over from settings. Moves ignore patterns from its own modal into a tab
of the folder edit modal. Advanced settings are in a tab instead of a expandable
section and versioning gets it's own tab.
Also added modal hidden event handler to remove the anchor in the url.
2018-03-18 01:10:13 +00:00
Simon Frei and Jakob Borg
5520022766
lig/ignore, lib/logger: Fix race and potential dead-locks when logging ( #4821 )
2018-03-17 16:49:12 +01:00
Simon Frei and Jakob Borg
55a7830ff9
lib/fs, lib/model: Make tests caching compatible ( fixes #4749 ) ( #4804 )
2018-03-13 14:03:10 +01:00
Simon Frei and Jakob Borg
b31bad1c4d
lib/model: Remove unused shouldIgnore function ( #4805 )
2018-03-12 20:16:40 +01:00
Simon Frei and Jakob Borg
8b4346c3ec
lib/scanner, lib/fs: Don't create file infos with abs paths ( fixes #4799 ) ( #4800 )
2018-03-12 13:18:59 +01:00
Simon Frei and Jakob Borg
2bdb37d412
cmd/syncthing: More information in help about -logfile option ( #4796 )
2018-03-12 13:17:12 +01:00
Simon Frei and Jakob Borg
3949b750f5
gui: In remote need use index and auto-expand if only one folder ( fixes #4759 ) ( #4781 )
2018-03-01 16:21:35 +01:00
Simon Frei and Jakob Borg
36251b86f7
lib/model: Mark deleted file as conflicting when un-ignoring ( #4776 )
...
This completes #4750 as a followup to #4765 .
2018-02-25 13:03:55 +01:00
Simon Frei and Jakob Borg
158859a1e2
lib: Handle metadata changes for send-only folders ( fixes #4616 , fixes #4627 ) ( #4750 )
...
Unignored files are marked as conflicting while scanning, which is then resolved
in the subsequent pull. Automatically reconciles needed items on send-only
folders, if they do not actually differ except for internal metadata.
2018-02-25 09:39:00 +01:00
Simon Frei and Jakob Borg
5822222c74
lib/model: More precise deletion detection ( fixes #2571 , fixes #4573 ) ( #4765 )
2018-02-25 09:27:54 +01:00
Simon Frei and Jakob Borg
6802505dda
lib/fs: Fix MkdirAll failure due to \\?\ ( fixes #4762 ) ( #4763 )
2018-02-16 15:19:20 +01:00
Simon Frei and Jakob Borg
68c1b2dd47
all: Revert simultaneously walk fs and db on scan ( fixes #4756 ) ( #4757 )
...
This reverts commit 6d3f9d5154 .
2018-02-14 08:59:46 +01:00
Simon Frei and GitHub
4955297bf6
lib/protocol: Invalid files should always lose ( #4747 )
2018-02-10 19:40:57 +01:00
Simon Frei and GitHub
6d3f9d5154
all: Simultaneously walk fs and db on scan ( fixes #2571 , fixes #4573 ) ( #4584 )
...
When scanner.Walk detects a change, it now returns the new file info as well as the old file info. It also finds deleted and ignored files while scanning.
Also directory deletions are now always committed to db after their children to prevent temporary failure on remote due to non-empty directory.
2018-02-10 16:56:53 +01:00
Simon Frei and Jakob Borg
3f4f6d5787
gui: Handle paused folders and fix translation strings for fs watcher (ref #4713 ) ( #4740 )
2018-02-07 13:46:27 +01:00
Simon Frei and Jakob Borg
8a3e584c19
lib/fs: Introduce walkfs debug facility ( #4712 )
2018-02-05 11:07:56 +01:00
Simon Frei and Jakob Borg
f87f13081b
all: Display fs watcher status and retry starting it (ref #4552 ) ( #4713 )
2018-02-04 22:46:24 +01:00
Simon Frei and Jakob Borg
c7cf361a96
vendor: Update github.com/zillode/notify ( #4734 )
2018-02-04 22:37:32 +01:00
Simon Frei and Jakob Borg
14a5561e43
lib/db: Fix benchmarks
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4708
2018-01-28 11:26:01 +00:00
Simon Frei and Jakob Borg
a0514bb1a7
gui: Add missing translation string to log viewer
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4714
2018-01-28 08:40:06 +00:00
Simon Frei and Jakob Borg
80079e8322
lib/fs: Use correct facility name
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4710
2018-01-27 12:52:48 +00:00
Simon Frei and Jakob Borg
ae760798e1
gui: Display rescan button when out of sync and remove deprecated folder state
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4704
2018-01-27 09:10:11 +00:00
Simon Frei and Jakob Borg
364f61bda6
lib/db: Update global counts on invalidation ( fixes #4701 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4702
2018-01-27 09:09:13 +00:00
Simon Frei and Jakob Borg
885e3f19bd
lib/ignores: Update lines even if patterns didn't change ( fixes #4689 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4690
2018-01-20 07:52:57 +00:00
Simon Frei and Audrius Butkevicius
93b5180e62
lib/model: Refactor Index/IndexUpdate
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4688
LGTM: calmh, AudriusButkevicius
2018-01-19 14:33:16 +00:00
Simon Frei and Audrius Butkevicius
fae2ca8458
lib/db: Do not modify underlying array of argument
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4685
2018-01-18 12:40:43 +00:00
Simon Frei and Jakob Borg
a1761795fe
lib/ignore: Only handle lines prefixed with #include specially ( fixes #4680 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4684
LGTM: AudriusButkevicius, calmh
2018-01-17 16:56:53 +00:00
Simon Frei and Jakob Borg
bd63fd73b1
lib/model: Microoptimization of unifySubs and blockDiff
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4671
LGTM: AudriusButkevicius, calmh
2018-01-14 21:52:41 +00:00
Simon Frei and Audrius Butkevicius
fecb21cdb1
gui: New rest endpoint to get errors when web UI is opened
...
Since #4340 pulls aren't happening every 10s anymore and may be delayed up to 1h.
This means that no folder error event reaches the web UI for a long time, thus no
failed items will show up for a long time. Now errors are populated when the
web UI is opened.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4650
LGTM: AudriusButkevicius
2018-01-14 17:01:06 +00:00
Simon Frei and Audrius Butkevicius
f1c73999be
gui: Count deleted items for remote out of sync items display ( fixes #4668 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4669
LGTM: calmh, AudriusButkevicius
2018-01-14 12:08:40 +00:00
Simon Frei and Audrius Butkevicius
341b9691a7
lib/connections, lib/model: Additional connection info in logs ( fixes #4499 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4665
2018-01-12 11:27:55 +00:00
Simon Frei and Jakob Borg
d87287c0d0
gui: Prevent error without completion and nicer wrapping ( fixes #4636 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4637
2018-01-05 14:41:40 +00:00
Simon Frei and Audrius Butkevicius
841205dbfe
lib/model: Check for invalid filenames after ignore patterns
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4607
LGTM: calmh, AudriusButkevicius
2017-12-25 17:54:34 +00:00
Simon Frei and Jakob Borg
8fa2b7765a
gui, lib/model: Display list of files needed by remote ( fixes #4369 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4559
LGTM: AudriusButkevicius, calmh
2017-12-15 20:01:56 +00:00
Simon Frei
cce634f340
lib/model: Improve scan scheduling and dir del during pull ( fixes #4475 #4476 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4493
2017-12-07 08:42:03 +00:00
Simon Frei
c005b8dcb0
lib/fs: Prolong test timeout on darwin, hopefully fixing flakyness
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4576
2017-12-06 22:07:08 +00:00
Simon Frei and Jakob Borg
ce29d3a574
all: Various debug logging improvements
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4529
2017-11-22 08:05:27 +00:00
Simon Frei and Jakob Borg
6cf01c1d30
lib/model: Don't update ignore hash when pull fails
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4522
2017-11-17 12:42:41 +00:00
Simon Frei and Audrius Butkevicius
4efff736b3
lib/connections: Consistent log levels & polish ( fixes #4510 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4511
2017-11-14 21:49:36 +00:00
Simon Frei and Jakob Borg
fa12a18190
lib/model: Handle type changes when pulling (ref #4505 #4506 #4507 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4509
LGTM: AudriusButkevicius, calmh
2017-11-13 15:16:27 +00:00
Simon Frei and Jakob Borg
c080f677cb
all: Add invalid/ignored files to global list, announce to peers ( fixes #623 )
...
This lets us determine accurate completion status for remote peers when they
have ignored files.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4460
2017-11-11 19:18:17 +00:00
Simon Frei and Jakob Borg
ec4c3bae0d
lib/watchaggregator: Don't care about timings during testing on darwin
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4502
2017-11-10 17:05:31 +00:00
Simon Frei and Jakob Borg
f6ea2a7f8e
lib/model: Trigger pulls instead of pulling periodically
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4340
2017-11-07 06:59:35 +00:00
Simon Frei
b999b58049
lib/watchaggregator: Relax test timing requirement for the benefit of macos
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4469
2017-10-26 21:09:10 +00:00
Simon Frei and Jakob Borg
2953fe40d1
lib/model: Add initial noop watch cancel func ( fixes #4464 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4465
2017-10-26 13:50:30 +02:00