Simon Frei and Audrius Butkevicius
841205dbfe
lib/model: Check for invalid filenames after ignore patterns
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4607
LGTM: calmh, AudriusButkevicius
2017-12-25 17:54:34 +00:00
Simon Frei and Jakob Borg
8fa2b7765a
gui, lib/model: Display list of files needed by remote ( fixes #4369 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4559
LGTM: AudriusButkevicius, calmh
2017-12-15 20:01:56 +00:00
Simon Frei
cce634f340
lib/model: Improve scan scheduling and dir del during pull ( fixes #4475 #4476 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4493
2017-12-07 08:42:03 +00:00
Simon Frei
c005b8dcb0
lib/fs: Prolong test timeout on darwin, hopefully fixing flakyness
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4576
2017-12-06 22:07:08 +00:00
Simon Frei and Jakob Borg
ce29d3a574
all: Various debug logging improvements
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4529
2017-11-22 08:05:27 +00:00
Simon Frei and Jakob Borg
6cf01c1d30
lib/model: Don't update ignore hash when pull fails
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4522
2017-11-17 12:42:41 +00:00
Simon Frei and Audrius Butkevicius
4efff736b3
lib/connections: Consistent log levels & polish ( fixes #4510 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4511
2017-11-14 21:49:36 +00:00
Simon Frei and Jakob Borg
fa12a18190
lib/model: Handle type changes when pulling (ref #4505 #4506 #4507 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4509
LGTM: AudriusButkevicius, calmh
2017-11-13 15:16:27 +00:00
Simon Frei and Jakob Borg
c080f677cb
all: Add invalid/ignored files to global list, announce to peers ( fixes #623 )
...
This lets us determine accurate completion status for remote peers when they
have ignored files.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4460
2017-11-11 19:18:17 +00:00
Simon Frei and Jakob Borg
ec4c3bae0d
lib/watchaggregator: Don't care about timings during testing on darwin
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4502
2017-11-10 17:05:31 +00:00
Simon Frei and Jakob Borg
f6ea2a7f8e
lib/model: Trigger pulls instead of pulling periodically
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4340
2017-11-07 06:59:35 +00:00
Simon Frei
b999b58049
lib/watchaggregator: Relax test timing requirement for the benefit of macos
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4469
2017-10-26 21:09:10 +00:00
Simon Frei and Jakob Borg
2953fe40d1
lib/model: Add initial noop watch cancel func ( fixes #4464 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4465
2017-10-26 13:50:30 +02:00
Simon Frei and Jakob Borg
4b69d0e093
lib/model: Add initial noop watch cancel func ( fixes #4464 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4465
2017-10-26 11:49:06 +00:00
Simon Frei and Jakob Borg
7ba9e7c322
lib/db: Filter unchanged files when updating and polish
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4426
2017-10-24 20:05:29 +00:00
Simon Frei and Jakob Borg
dc42db444b
lib/model, lib/config: Refactor folder health/error handling ( fixes #4445 , fixes #4451 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4455
LGTM: AudriusButkevicius, calmh
2017-10-24 07:58:55 +00:00
Simon Frei and Jakob Borg
46becc5338
build: Handle split GOPATH
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4447
2017-10-21 17:37:06 +00:00
Simon Frei and Audrius Butkevicius
20fac4bb80
main: Improve logging for initial config loading (ref #4431 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4436
2017-10-21 09:00:24 +00:00
Simon Frei and Audrius Butkevicius
d84b6bb822
build: Warn when being executed outside of gopath
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4425
2017-10-20 23:10:55 +00:00
Simon Frei and Audrius Butkevicius
55b63941b8
cmd/syncthing: Add fswatcher and remove useAPIKey stats
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4438
2017-10-20 16:25:20 +00:00
Simon Frei
e70003737b
lib/fs: make watcher tests even more darwin slowness resistant
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4439
2017-10-20 15:59:18 +00:00
Simon Frei and Jakob Borg
c704ba9ef9
gui: "versioner" -> "versioning" and add missing translations
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4435
2017-10-20 13:55:22 +00:00
Simon Frei and Jakob Borg
694a7de59d
build: Correct import paths for vet tools
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4420
2017-10-15 10:39:50 +00:00
Simon Frei and Audrius Butkevicius
e588bb29b9
lib/model: remove unused folderFs member from Model
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4389
2017-09-21 09:03:36 +00:00
Simon Frei and Jakob Borg
1088eb12ea
lib/model: Fix logging inconsistencies ( fixes #4375 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4376
2017-09-18 11:56:19 +00:00
Simon Frei and Jakob Borg
f7d2c58783
lib/model: Deduplicate folder loops
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4352
LGTM: AudriusButkevicius, calmh
2017-09-07 06:17:47 +00:00
Simon Frei and Jakob Borg
9dbc509996
lib/ignore: Consistent behaviour for nil *Matcher
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4310
2017-09-06 06:39:18 +00:00
Simon Frei and Jakob Borg
c41aaad3bb
lib/ignore: Ignore duplicate lines in .stignore
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4350
LGTM: AudriusButkevicius, calmh
2017-09-04 12:46:19 +00:00
Simon Frei and Jakob Borg
55e0ac3e24
lib/model: Make puller retrying and logging less aggressive
...
Currently all errors during pulling and the first of these errors again on
finishing are logged to info. Besides that the errors logged when finishing
are stored in f.errors. This PR moves all logging during pulling to the debug
channel (they might still be relevant in some obscure debugging case) and
uses the stored errors to log the main error per fail when all pulling
iterations are done and failed.
Additional instead of trying 11 times it now only tries 3 times.
This is the first part of what is discussed here:
https://forum.syncthing.net/t/reduce-verboseness-of-puller/10261
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4338
2017-09-02 06:05:55 +00:00
Simon Frei and Audrius Butkevicius
ddf6d64faa
lib/model: Create folders via newFolder
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4329
2017-08-25 19:47:01 +00:00
Simon Frei and Jakob Borg
c7221b035d
gui: Round down in devices completion (consistent with folders)
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4325
2017-08-24 04:26:12 +00:00
Simon Frei and Jakob Borg
0ca0e3e9bd
lib/model: GetIgnores: Don't return error for no .stignore file
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4311
2017-08-22 06:48:25 +00:00
Simon Frei and Audrius Butkevicius
ab8c2fb5c7
lib/model: Fix race in GetIgnores ( fixes #4300 )
...
In addition this function returned an error when .stignore file was not
present, which is perfectly valid. Also removed inconsistent nil check in
ignores.go (only relevant for tests) and adjusted walk.go to do what it says
in comments (check if Matcher is nil) to prevent nil deref in tests.
Originally reported in:
https://forum.syncthing.net/t/reason-for-panic-maybe-too-little-ram/10346
Regression from #3996
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4301
2017-08-12 17:10:43 +00:00
Simon Frei and Jakob Borg
77578e8aac
gui: Don't set default path editing existing folders without label ( fixes #4297 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4298
LGTM: calmh
2017-08-10 15:31:25 +00:00
Simon Frei and Jakob Borg
a04b92332f
gui, lib/config: Add default path for new folders ( fixes #2157 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4192
2017-07-20 13:16:54 +00:00
Simon Frei and Jakob Borg
b75c9f2bbb
lib/ignores: Don't add text from includes to lines ( fixes #4249 )
...
Otherwise all the lines from includes will be shown in the web UI instead of
just the #include ... line. This problem was introduced in #3996 .
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4248
LGTM: calmh
2017-07-06 11:44:11 +00:00
Simon Frei and Jakob Borg
8d13e01342
gui: Fix discovered devices list (follow-up to #4186 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4239
2017-06-29 13:47:42 +00:00
Simon Frei and Jakob Borg
98cfc204ca
gui: Add dropdown menu to choose discovered devices to device modal ( fixes #4157 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4186
LGTM: AudriusButkevicius, calmh
2017-06-16 15:27:09 +00:00
Simon Frei and Jakob Borg
9c4175715a
gui: Reset ignore input field when adding remote share ( fixes #4203 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4204
LGTM: AudriusButkevicius, calmh
2017-06-09 05:41:19 +00:00
Simon Frei and Jakob Borg
719c313b23
cmd/syncthing, lib/logger: Set debug flags on SetDebug for tests
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4187
2017-06-02 07:04:06 +00:00
Simon Frei and Audrius Butkevicius
dd6bb6d5fd
gui: Reset warnings about nested folder roots ( fixes #3433 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4173
2017-05-23 19:54:56 +00:00
Simon Frei and Jakob Borg
0b854dff9d
lib/ignore: Don't match root (".")
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4122
2017-05-01 16:58:08 +00:00
Simon Frei and Jakob Borg
9de6cdddfd
script: Ignore units and allow translated strings as translate-values
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4120
2017-04-29 15:48:00 +00:00
Simon Frei and Jakob Borg
914b09fd1f
lib/model: Create root directory for paused folders ( fixes #4094 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4095
2017-04-23 23:50:56 +00:00
Simon Frei and Jakob Borg
6b188ebcf3
lib/model: Mark initial scan as finished even if failed and refactor ( fixes #4103 )
...
The mechanism to disallow manual scans before the initial scan completed
(#3996 ) , had the side effect, that if the initial scan failed, no further
scans are allowed. So this marks the initial scan as finished regardless of
whether it succeeded or not.
There was also redundant code in rofolder and a pointless check for folder
health in scanSubsIfHealthy (happens in internalScanFolderSubdirs as well).
This also moves logging from folder.go to ro/rw-folder.go to include the
information about whether it is send-only or send-receive
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4104
2017-04-20 00:20:34 +00:00
Simon Frei and Jakob Borg
5521759b23
lib/model: TestIgnores: Add ms sleep on all platforms (ref #3986 #3996 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4083
2017-04-06 09:55:54 +00:00
Simon Frei and Audrius Butkevicius
25b314f5f1
lib/model, gui: Allow creating and editing ignores of paused folders ( fixes #3608 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3996
LGTM: calmh, AudriusButkevicius
2017-04-01 09:58:06 +00:00
Simon Frei and Jakob Borg
1ad547fb65
gui, script: Translate discovery popover and detect it in translate script
...
Skip-check: pr-solaris
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4061
2017-03-25 11:56:51 +00:00
Simon Frei and Audrius Butkevicius
88dfd634e5
script, gui: Silence useless warnings in translation script
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4034
LGTM: AudriusButkevicius
2017-03-18 00:27:22 +00:00
Simon Frei and Jakob Borg
601a4fac1a
cmd/syncthing: Accept absolute -home paths (regression from #3183 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4033
2017-03-09 14:57:12 +00:00
Simon Frei and Jakob Borg
1b08176583
gui: Update translation strings
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4031
2017-03-08 12:38:25 +00:00
Simon Frei and Jakob Borg
1c29a93013
lib/events, cmd/syncthing: Correct GlobalID in debug and mark "since" parameter optional
...
Skip-check: metalint
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4025
2017-03-07 05:44:47 +00:00
Simon Frei and Jakob Borg
416811a2a9
cmd/syncthing, lib/config: Pause/resume all devices whithout argument
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3989
LGTM: AudriusButkevicius, calmh
2017-03-04 07:54:13 +00:00
Simon Frei and Jakob Borg
c20d612736
cmd/syncthing, lib/model: Handle rel/abs paths for config/protected paths ( fixes #3183 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3995
2017-03-04 07:49:48 +00:00
Simon Frei and Jakob Borg
22903df2c1
lib/model: Meaningful error messages for paused folders
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3977
LGTM: AudriusButkevicius, calmh
2017-02-09 20:29:56 +00:00
Simon Frei and Jakob Borg
237893ead3
cmd/syncthing: Only delay next scan (via REST) if the scan succeeds
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3927
2017-02-05 18:17:44 +00:00
Simon Frei and Audrius Butkevicius
dbb3a34887
lib/ignore: Centralize handling of temporary filenames ( fixes #3899 )
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3901
LGTM: calmh, AudriusButkevicius
2017-01-17 07:33:48 +00:00
Simon Frei and Audrius Butkevicius
4160ce674d
model: consistently use cfg when referring to config instance and not package
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3755
2016-11-22 23:14:20 +00:00
Simon Frei and Jakob Borg
7c37301c91
lib/ignore: Add directory separator to glob.Compile call
...
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3674
LGTM: calmh
2016-10-21 07:33:40 +00:00